PRO-7053: enable document-versions for autopublished docs #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
previously approved these changes
Jan 30, 2025
| @@ -5,6 +5,7 @@ module.exports = { | |||
| pluralLabel: 'apostrophe:fileTags', | |||
| quickCreate: false, | |||
| autopublish: true, | |||
| versions: true, | |||
There was a problem hiding this comment.
Yeah... we could do this in an improvement in the document-versions module, but this is a lot less typing and harms nothing when it is not present. 👍
| @@ -80,6 +80,7 @@ export default { | |||
|
|
|||
| if (modal) { | |||
| await apos.modal.execute(modal, { | |||
| moduleName: this.moduleOptions.name, | |||
There was a problem hiding this comment.
So you can look up options of it, OK
ETLaurent
changed the title
…053-document-versions-autopublish
Merged
10 tasks
boutell
previously approved these changes
Feb 7, 2025
ETLaurent
commented
Feb 8, 2025
| @@ -48,6 +48,7 @@ module.exports = { | |||
| searchable: false, | |||
| slugPrefix: 'user-', | |||
| localized: false, | |||
| versions: false, | |||
There was a problem hiding this comment.
@boutell added this as an extra security
boutell
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See: https://github.com/apostrophecms/document-versions/pull/73
And:
https://github.com/apostrophecms/palette/pull/110
apostrophecms/import-export#102
Cypress tests:
https://github.com/apostrophecms/testbed/pull/323
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: