PRO-6876: implicit properties for reverse relationship projectionsnship projections #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
commented
Feb 6, 2025
| @@ -1751,7 +1751,9 @@ module.exports = { | |||
| const add = []; | |||
| const remove = []; | |||
|
|
|||
| // Add type in projection by default | |||
| // Add fundamentals by default to allow Apostrophe's core | |||
There was a problem hiding this comment.
Unrelated update to clarify what happens here since it is more than just tpe
boutell
commented
Feb 6, 2025
| @@ -145,7 +148,8 @@ function getModules() { | |||
| label: 'Rel page', | |||
| type: 'relationship', | |||
| withType: 'default-page', | |||
| withRelationships: [ '_articles._topics' ], | |||
| // Intentionally revisits the articles in order to test reverse relationships | |||
There was a problem hiding this comment.
Normally it would be silly to loop back like this but it's a simple way to test the reverse relationship.
myovchev
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog