Updates breakpoint preview feature #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
approved these changes
Mar 24, 2025
docs/guide/breakpoint-preview.md
Outdated
| - Parameters like `orientation: landscape` or `orientation: portrait` do not apply to containers, as containers lack inherent orientation. | ||
| - Example of unsupported query: | ||
| - Parameters like `orientation: landscape` or `orientation: portrait` don't have equivalent behavior in container queries, as containers don't have the same orientation concept as viewports. | ||
| - Example of query with limited support: |
There was a problem hiding this comment.
Yeah, reading with fresh eyes, that wording is a little off
docs/guide/breakpoint-preview.md
Outdated
|
|
||
| /* Converted to */ | ||
| .element { | ||
| width: 50cqw; /* 50% of container width, not viewport */ |
There was a problem hiding this comment.
Does this have any practical pitfalls? Reading about it, it seems like it should be fine?
There was a problem hiding this comment.
I updated this to better describe the pitfalls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR updates the breakpoint preview documentation to reflect the limitations of the new PostCSS extension being used. Closes PRO-7372.
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: