Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community contribution ported from A2 version: nice source in browser #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boutell
Copy link
Member

@boutell boutell commented Apr 8, 2022

Summary

A contribution from the community. The user sees the XML as a nice tree instead of just text if they view sitemap.xml in the browser. Nothing else changes (it was already valid XML, this is for developer friendliness).

What are the specific steps to test this change?

  • Visit /sitemap.xml in browser in chrome, observe it is displayed nicely now rather than as text without tags

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@boutell boutell requested a review from ValJed April 8, 2022 14:42
Copy link

@ValJed ValJed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any changes with and without.. Maybe should be re tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants