-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update the AWS SDK auth #10834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the AWS SDK auth #10834
Conversation
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, digging more through the AWS C++ SDK, it seems like our current version already supports this but the function we use doesn't support. Some related issues for reference:
The proposed "solution" from AWS is: aws/aws-sdk-cpp#150 (comment)
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be related too: aws/aws-sdk-cpp#1963.
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
I got cmake work but not sure if we already have tests in place to test this particular code path, or we need a new one. @johscheuer #10837 |
The current AWS SDK version used doesn't support to assume a role. Based on aws/aws-sdk-cpp#1025 this was added in 1.11.150 of the SDK.
I still have to do the validation and make sure the cmake magic works.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)