-
Notifications
You must be signed in to change notification settings - Fork 343
Fix ArgumentParser build failure for WASI (WebAssembly System Interface) #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ArgumentParser is very useful for command-line tools that are built for wasm32-unknown-wasi and run on WebAssembly runtimes (e.g., wasmtime, wasmer, WasmKit). However, starting from version 1.6.0, the use of `DispatchSemaphore` has caused the build for wasm32-unknown-wasi to break. This change is intended to fix that issue.
@kkebo, thanks for this fix! Would you be willing to update https://github.com/apple/swift-argument-parser/blob/main/.github/workflows/pull_request.yml to include those WASM build tests? They could be in a |
@natecook1000 That's great! I've added the |
The CI failures on macOS seem to be an issue caused by the runner environment, so I don't think they're relevant to this PR. https://github.com/apple/swift-argument-parser/actions/runs/16066481137/job/45417662979?pr=794
https://github.com/apple/swift-argument-parser/actions/runs/16066481137/job/45417662980?pr=794
|
It seems that the same CI issue is occurring in another repository as well. https://github.com/apple/swift-collections/actions/runs/15969333028 |
Thanks! It looks like the install on the macOS runners has been changed - I'll get that updated in a different PR. |
I would vastly prefer this job be added to swift github workflows instead of just argument parser. Other swiftlang repos have the same need. |
@rauhul Let's get it merged here and then I can move it up into gh-workflows |
@swift-ci Please test |
Thanks again for these contributions, @kkebo! |
ArgumentParser is very useful for command-line tools that are built for wasm32-unknown-wasi and run on WebAssembly runtimes (e.g., wasmtime, wasmer, WasmKit). However, starting from version 1.6.0, the use of
DispatchSemaphore
has caused the build for wasm32-unknown-wasi to break.This PR is intended to fix that issue.
Checks
Checklist