Conversation
Motivation: ClientBootstrap currently stores one resolver instance, but DNS resolvers are generally single-use. Reusing a bootstrap with such a resolver can mix or reuse resolver state across connections. Modifications: Add NIODynamicResolver and configure ClientBootstrap to create one resolver per hostname connection, including the async path. Add a concurrent connection regression test. Result: A reusable ClientBootstrap can safely create fresh resolver instances for concurrent hostname connections. Signed-off-by: Aryan Singh K. <70511529+aryansk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ClientBootstrap currently stores one resolver instance, but DNS resolvers are generally single-use. Reusing a bootstrap with a single-use resolver makes it difficult to issue multiple hostname connections safely.
Modifications:
Result:
A reusable ClientBootstrap can safely create fresh resolver instances for concurrent hostname connections. The factory boundary avoids the shared mutable pairing problem identified in the earlier closed PR #2553.
Testing:
Closes #2434