Feature/no tsndr #12
Draft
Feature/no tsndr #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support EC256 keys and drop tsndr dependency since there is no support for non printable characters in the secrets
Log specific failure reason to allow faster troubleshooting
Log request headers for debugging
Use base64URL secret instead of base64 only
Accept base64url and base64 value as secret and convert conditionaly
Add arc code message handling and different conditions for failure to allow client applications to handle different error modes
Comment out DEBUG statement
Format return error with APPROOV prefix in json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.