-
Notifications
You must be signed in to change notification settings - Fork 15
Display distance and time info for wind/skew-t sources #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Instead of 4:35 time remaining, better to show local time with Z time (in brackets). Will be nice to see when the winds were downloaded. |
|
Rebased on 7b2b130. |
|
Two issues |
|
I opted to specify units not particularly because of the actual size of the unit, but rather to clarify what kind of unit was being conveyed. I found that a string such as I can look into extending the reception time for other received data. It should not be very difficult to implement. |
| String dir; | ||
| double bearing = getMagneticHeading(bearingIn, declination); | ||
| if ((bearing > dirDegrees) && (bearing <= (90 - dirDegrees))) { | ||
| dir = "SW of"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an issue as the direction is from the point touched. Of is required you are off of this heading
| } | ||
|
|
||
| Weather? winds; | ||
| String? station = WindsCache.locateNearestStation(showDestination.coordinate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with weather received from ADSB?
| @@ -0,0 +1,25 @@ | |||
|
|
|||
| class TimeZone { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a package for it 'tz' in pubspec.yaml.
| mpsTo = 2.23694; | ||
| toMps = 0.44704; | ||
| knotsTo = 1.15078; | ||
| distanceName = 'mi'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have all the places that use this been added this info? For example measuring tool?
| CachedNetworkImage image = CachedNetworkImage(imageUrl: url, cacheManager: FileCacheManager().networkCacheManager, errorWidget: errorImage,); | ||
| return Container(padding: const EdgeInsets.all(10), child: | ||
| InteractiveViewer(child: Container(color: Colors.white , alignment: Alignment.center, child: image))); | ||
| return ListView( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack is a better widget here
| return w24k; | ||
| } | ||
| else if (altitude == 30000) { | ||
| return w30k; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing as pilots are used to seeing negative temps.
apps4av
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has issues. While changes are good step forward, overall view is not considered. This will cause inconsistency across the app.



Improves the Wind screen in the following ways:
getGeneralDirectionFromhas been modified to only print the relevant direction, so it can be used here as wellThe general idea of these UI changes is to make some confusing/unclear reporting stations more clear. Many winds aloft reporting points in Alaska, the Pacific, and Canada have codes that do not correspond to widely known landmarks (e.g.
5AFis just an arbitrary point in the Pacific Ocean), and many radiosonde codes do not correspond to an airport code (e.g.OTXis the reporting code for Spokane, WA, which has no airport by that name/code). Therefore, giving some spatial relationship between the selected point and the corresponding wind data is necessary to get an idea of the reliability of the data being presented.Additionally, the times for the winds aloft forecasts and radiosonde launches are in UTC, which can be a bit of a hassle to quickly convert to local time.
Inverting the temperatures reported above 24k is mostly to remove text clutter from the menu, since new text has been added.