Skip to content

Fix tile filtering to use area overlap rather than only NW corner #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apps4av merged 2 commits into from
Oct 19, 2025
Merged

Fix tile filtering to use area overlap rather than only NW corner #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
304857b
Fix tile filtering to use area overlap instead of only testing the co…
jonhnet Oct 6, 2025
0051281
Fix tile filtering to use area overlap instead of only checking north…
jonhnet Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,6 @@
import projection


def is_in(area, lon, lat):
x_u, y_u, x_l, y_l = area
if lat <= y_u and lat >= y_l and lon >= x_u and lon <= x_l:
return True
return False


def list_crawl(url, match):
charts = []
html_page = urllib.request.urlopen(url)
Expand Down Expand Up @@ -126,11 +119,15 @@ def zip_charts(list_of_all_tiles, chart):
y_tile = int(tokens[len(tokens) - 1].split(".")[0])
x_tile = int(tokens[len(tokens) - 2])
z_tile = int(tokens[len(tokens) - 3])
lon_tile, lat_tile, lon1_tile, lat1_tile = projection.findBounds(x_tile, y_tile, z_tile)
lon_min, lat_max, lon_max, lat_min = projection.findBounds(x_tile, y_tile, z_tile)

# include zoom 7 and below in every chart
for count in range(len(regions)):
if is_in(region_coordinates[count], lon_tile, lat_tile) or z_tile <= 7:
region_lon_min, region_lat_max, region_lon_max, region_lat_min = region_coordinates[count]
# Check if tile overlaps region anywhere
lon_overlap = lon_max >= region_lon_min and lon_min <= region_lon_max
lat_overlap = lat_max >= region_lat_min and lat_min <= region_lat_max
if (lon_overlap and lat_overlap) or z_tile <= 7:
zip_files[count].write(tile)
manifest_files[count].write(tile + "\n")

Expand Down