-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Gin request query and payload #280
Open
tombruijn
wants to merge
6
commits into
main
Choose a base branch
from
go-collector-parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with:
And a JSON payload:
|
Add a middleware to the Gin app to record query parameters and request payload data. We can add this to the docs for Go apps using OpenTelemetry.
0a38d4d
to
b2ef813
Compare
Make testing easier by setting these values for the root endpoint.
unflxw
requested changes
Feb 26, 2025
These imports crash the CI.
This change makes it so that the app itself can still access the request payload after we've read it by restoring it on the request object.
No need to do `.Key` and then the value if you can set both in the same function call.
I forgot the `request_` prefix for these filtering options so nothing was filtered.
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a middleware to the Gin app to record query parameters and request payload data.
We can add this to the docs for Go apps using OpenTelemetry.