addressing review comments

appsmithorg · Mar 12, 2025 · eab2050 · eab2050
1 parent b15dd32
commit eab2050
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts b/app/client/src/ce/navigation/FocusStrategy/AppIDEFocusStrategy.ts
@@ -292,7 +292,7 @@ export const AppIDEFocusStrategy: FocusStrategy = {
     }
 
     // We do not have to add any query params because this url is used as the key
-    return parentUrl.split("?")[0] + `#${branch}`;
+    return `${parentUrl.split("?")[0]}#${branch}`;
   },
   *waitForPathLoad(currentPath: string, previousPath?: string) {
     if (previousPath) {

diff --git a/app/client/src/ce/navigation/FocusStrategy/types.ts b/app/client/src/ce/navigation/FocusStrategy/types.ts
@@ -33,7 +33,9 @@ export interface FocusStrategy {
   getEntityParentUrl: (
     entityInfo: FocusEntityInfo,
     parentEntity: FocusEntity,
-  ) => Generator<unknown, string, unknown>;
+    // TODO: Fix this the next time the file is edited
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  ) => Generator<any, string, any>;
   /** Define a wait (saga) before we start setting states  **/
   waitForPathLoad: (
     currentPath: string,