fix: updated the propertpaneview file to hide the copy and delete ico… #35227
Conversation
…n for Container_widget in list_widget _V2.
WalkthroughThe recent changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PropertyPane
participant getActions
User->>PropertyPane: Interacts with widget
PropertyPane->>getActions: Calls getActions(widgetProperties, onCopy, onDelete)
getActions-->>PropertyPane: Returns actions array
PropertyPane->>User: Displays action buttons
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/client/src/pages/Editor/PropertyPane/PropertyPaneView.test.tsx (1 hunks)
- app/client/src/pages/Editor/PropertyPane/PropertyPaneView.tsx (2 hunks)
Additional comments not posted (4)
app/client/src/pages/Editor/PropertyPane/PropertyPaneView.test.tsx (2)
11-15: Test case approved.The test case correctly verifies that
getActionsreturns an empty array forCONTAINER_WIDGET.
17-21: Test case approved.The test case correctly verifies that
getActionsreturns an array with actions forLIST_WIDGET_V2.app/client/src/pages/Editor/PropertyPane/PropertyPaneView.tsx (2)
71-107: Function approved.The
getActionsfunction correctly generates action buttons based on the widget type.
244-247: Integration approved.The
getActionsfunction is correctly integrated withinPropertyPaneViewusinguseMemo.
|
hi @chandannkumar @delippitchika @ashit-rath ,could you Please assign reviwers to this PR. thank you. |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
hi @chandannkumar @dilippitchika @ashit-rath @Nikhil-Nandagopal ,could you Please assign reviwers to this PR. thank you. |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
hi @chandannkumar @dilippitchika @NilanshBansal @Nikhil-Nandagopal ,could you Please assign reviwers to this PR. thank you |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
hi @chandannkumar @dilippitchika @NilanshBansal @Nikhil-Nandagopal @rohan-arthur ,could you Please assign reviwers to this PR. thank you |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
Description:
The delete and copy icons in porpertpane should be hidden for container widget, since they are not usefull inside list_widget_v2.
fixes: Github_Issue - 20273
Changes in PR:
1.updated the code in the PropertyPaneView to render the Icons Properly by adding a function called getActions , which depends on the widgetProperties.
2.written the test case for the new code added.
Snapshots:
Before
After:
Test case:
hi @chandannkumar @delippitchika @ashit-rath , Please review this PR.
Summary by CodeRabbit
New Features
Refactor