Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MS Sql test container version upgrade #36445

Open
wants to merge 2 commits into
base: release
Choose a base branch
from

Conversation

AnaghHegde
Copy link
Member

@AnaghHegde AnaghHegde commented Sep 20, 2024

Description

Upgrade the ms sql test container version from 1.0.3 to 1.0.7

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Docker image version for the MSSQL Server container to enhance stability and performance.
    • Ensured continued functionality with license acceptance and port exposure.

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The recent changes involve an update to the MssqlTestDBContainerManager class, specifically modifying the getMssqlDBForTest method. The primary alteration is the Docker image version for the MSSQLServerContainer, which has been upgraded from 1.0.3 to 1.0.7. This change retains the existing functionality, including license acceptance and port exposure.

Changes

File Change Summary
app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java Updated Docker image version from 1.0.3 to 1.0.7 in getMssqlDBForTest method.

Suggested labels

skip-changelog, ok-to-test

In the world of code, a change so bright,
Upgrading the image, making it right.
From 1.0.3 to 1.0.7, we cheer,
A smoother experience, let’s give a cheer!
With ports open wide, and licenses clear,
Our tests shall run swiftly, let’s spread the cheer! 🎉


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1cf043c and d767919.

Files selected for processing (1)
  • app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java (1 hunks)
Additional comments not posted (1)
app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java (1)

Line range hint 27-31: Great work on upgrading the Docker image version! 🌟

Class, the change in the Docker image version from 1.0.3 to 1.0.7 for the MSSQLServerContainer is a positive update. This newer version likely includes important bug fixes, performance enhancements, and possibly even some new features that can improve the reliability and efficiency of our test environment. 👨‍🏫

I appreciate that you've maintained the existing functionality of accepting the license and exposing port 1433 while making this version upgrade. This ensures that the change is isolated and should not introduce any breaking changes to the method signature or core functionality. 🙌

Let's embrace this version upgrade and leverage the benefits it brings to our testing process! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 20, 2024
Copy link

Failed server tests

  • com.external.plugins.MssqlGetDBSchemaTest#
  • com.external.plugins.MssqlPluginTest#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant