-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added action to update metawidgets without triggering eval #39618
base: release
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request introduces a new function, Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant DA as Dispatch Action
participant A as metaWidgetActions
participant R as metaWidgetsReducer
participant M as modifyMetaWidgets
U->>DA: Dispatch modifyMetaWidgetsWithoutEval(payload)
DA->>A: Call modifyMetaWidgetsWithoutEval(payload)
A-->>DA: Returns action { type: MODIFY_META_WIDGETS_WITHOUT_EVAL, payload }
DA->>R: Pass action to metaWidgetsReducer
R->>M: Process action via modifyMetaWidgets
M-->>R: Return updated meta widgets state
R-->>DA: Updated state propagated
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
PR adds a new action
MODIFY_META_WIDGETS_WITHOUT_EVAL
which does exactly same asMODIFY_META_WIDGETS
in the metaWidgetsReducer expect the difference thatMODIFY_META_WIDGETS_WITHOUT_EVAL
is not part of evaluationActionsList which helps updating meta widgets without triggering eval.This is required for UI module rendering in app
PR for https://github.com/appsmithorg/appsmith-ee/pull/6496
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity,@tag.Widget"
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13787545433
Commit: 1dfda48
Cypress dashboard.
Tags: @tag.Sanity,@tag.Widget
Spec:
The following are new failures, please fix them before merging the PR:
Tue, 11 Mar 2025 13:37:26 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?