feat: replaced pink 1 with pink2 in documents permission component #2128
Conversation
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-21 12:56:36 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-21 12:59:39 CET |
| {:else} | ||
| <Alert type={alertType} isStandalone> | ||
| <Alert.Inline status={alertType === 'default' ? 'info' : alertType}> |
There was a problem hiding this comment.
lets make the alertType the same type as status from Alert.Inline so we don't have to do these kind of checks.
| @@ -343,7 +344,8 @@ | |||
| {/each} | |||
| </Table.Root> | |||
| <div class="u-flex u-flex-vertical u-gap-16"> | |||
There was a problem hiding this comment.
Lets use the Layout.Stack here.
| source: 'function_keys_card', | ||
| destination: 'docs' | ||
| })} | ||
| <div class="u-margin-block-start-24"> |
There was a problem hiding this comment.
why do we need this margin here?
| })} | ||
| <div class="u-margin-block-start-24"> | ||
| <Alert.Inline status="warning" dismissible on:dismiss={() => (showAlert = false)}> | ||
| <svelte:fragment slot="title">Your function is outdated</svelte:fragment> |
There was a problem hiding this comment.
Use the title prop on Alert.Inline.
| <svelte:fragment slot="title">Your function is outdated</svelte:fragment> | ||
| Update your function version to make use of new features including build commands and | ||
| HTTP data in your executions. To update, follow the steps outlined in our | ||
| <a |
There was a problem hiding this comment.
We could try using the Link/Anchor components here.
| @@ -45,7 +46,7 @@ | |||
| <svelte:fragment slot="aside"> | |||
| {#if isCloud} | |||
| {@const size = humanFileSize(sizeToBytes(service, 'MB', 1000))} | |||
| <Alert type="info"> | |||
| <Alert.Inline status="info"> | |||
| <p class="text"> | |||
There was a problem hiding this comment.
we don't need this class or the p tag itself. Pl. verify.
What does this PR do?
Replaced pink 1 with pink 2 alert component n documents permission component
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes