Skip to content

[mini] initialize (empty) secondary vector #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[mini] initialize (empty) secondary vector #444

wants to merge 2 commits into from

Conversation

SeverinDiederichs
Copy link
Collaborator

@SeverinDiederichs SeverinDiederichs commented Oct 3, 2025 •
edited
Loading

This initializes an empty secondary vector when returning a GPU step to the CPU. This is needed such that the access to the secondary does not crash:

  const std::vector<const G4Track*>  *secondaryVector = aStep->GetSecondaryInCurrentStep();
  secondaryVector->size(); <- currently crashes as it is a nullPtr

With this PR the secondary vector is available, just empty.

This PR is needed to run Athena with the Sim_tf transform.

@SeverinDiederichs SeverinDiederichs added the enhancement Type: New feature or request label Oct 3, 2025
@phsft-bot
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuanGonzalezCaminero JuanGonzalezCaminero Awaiting requested review from JuanGonzalezCaminero

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement Type: New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SeverinDiederichs @phsft-bot