Fix cases where no plot is generated and add tests to validate saving of plots #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaydel
force-pushed
the
szaydel/objectify
branch
from
9936cb3 to
72b7f47
Compare
szaydel
force-pushed
the
szaydel/objectify
branch
from
72b7f47 to
5926102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Please review this changeset carefully and confirm that it is still in line with project goals. Mainly, I focused on adding some basic tests for validating plot generation. In my tests checksums were consistently as expected, but I am not positive that I can expect this to always be true. I am also not sure if TravisCI can run tests where temp files are generated and checksums are obtained by reading those files. This needs further testing.
Perhaps it might be good to move these into their own branch and I would not mind fetching that branch and testing with it. It is possible that because automatic merge won't be done, that a merge conflict needs further attention.
Thank you, Sam.