Fix settings toggle overflow + hotkey capture, add theme picker (v0.1.12)#16
Merged
Merged
Conversation
….12) - Toggle switch thumb missing left-0 rendered outside its track. - Global hotkey capture never saw keystrokes matching the currently bound combo, since the OS-level global shortcut intercepted it first; now suspended for the duration of a capture session and re-armed on cancel/failure/unmount. - Appearance pane gains a Dark/Light theme picker alongside the existing accent color swatches, backed by new ink/canvas CSS variables so every settings-window surface repaints live. - Bump to v0.1.12, changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Toggle switch thumb overflowed its track.
Toggle's knob<span>had noleftanchor, so the browser's static-position fallback rendered it flush against — and partly outside — the track's right edge when checked. Addedleft-0sotranslate-x-[3px]/translate-x-[19px]are relative to a known origin. Verified viagetBoundingClientRect: thumb now sits a consistent 3px inset on both states.Global hotkey capture never saw keystrokes. The bound toggle shortcut stays registered as an OS-level global hotkey the entire time the settings window is open. Pressing that combo (or anything already intercepted) while recording a new one never reached the capture
keydownlistener — the OS grabbed it first, so "Listening…" looked permanently stuck. Addedsuspend_toggle_shortcut/resume_toggle_shortcutTauri commands; the settings window suspends the active hotkey for the duration of a capture session and re-arms it on cancel/failure/unmount (a successful capture re-registers the new combo instead, via the existingupdate_settings→rebind_togglepath).Added
ink/canvasTailwind colors backed by CSS variables (--ink-rgb,--canvas-rgb) replace every hardcodedwhite/*/hsl(32,14%,7%)token across the settings window;theme.ts:applyTheme()flips them via adata-themeattribute, so switching themes repaints the whole window live, no reload.Verification
tsc --noEmitclean,cargo checkclean.getBoundingClientRect, confirmed keystroke capture round-trips correctly, and screenshotted General/Appearance/Extensions in both themes for full contrast/legibility.src-tauri/tauri.conf.json+Cargo.tomlto 0.1.12, added CHANGELOG entry.