B4 (part 2): React Plugin Manager + Settings; delete legacy ui/#8
Open
archdex-art wants to merge 3 commits into
Open
B4 (part 2): React Plugin Manager + Settings; delete legacy ui/#8archdex-art wants to merge 3 commits into
archdex-art wants to merge 3 commits into
Conversation
Port the Plugin Manager from legacy ui/ into React: list installed extensions, install from a folder path, enable (with a capability-permission consent dialog), and uninstall — plus the new B1 trust-consent for unsandboxed script extensions (a distinct, explicit "this runs with full privileges" confirm before `set_extension_trusted`). Reachable via a "Manage Extensions" palette command. Adds `ExtensionInfo`/`PermissionInfo` types + browser-dev mocks. tsc + vite build clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Port the Settings panel (global shortcut, hide-on-blur, theme) from ui/ into React, reachable via a "Settings" palette command, persisted through get_settings/update_settings. Delete the legacy vanilla-JS `ui/` front-end entirely. It was already dead code — `frontendDist` points at `react-command-palette/dist`, and nothing in Rust or the Tauri config referenced `ui/`. With the Plugin Manager and Settings now in React, there is one front-end, one build path, one source of truth (B4 complete). tsc + vite build clean (395 modules). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`timeout_kills_runaway_script` (renamed `nonzero_exit_is_classified_as_failure`) spawns a subprocess and asserts the non-zero-exit classification. Under heavy parallel test load — amplified by B1/B2's concurrent extension fan-out — the spawn can transiently fail (EAGAIN) and surface a different error variant. Retry past transient Spawn/Timeout outcomes and assert the steady-state classification. Stable 25/25 locally; was the only red job on this branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes B4 — one front-end, one build path, one source of truth.
What
set_extension_trusted). Opened via a "Manage Extensions" palette command.get_settings/update_settings. Opened via a "Settings" command.ui/(the legacy vanilla-JS front-end, ~3.4k lines). It was already dead code:frontendDistpoints atreact-command-palette/distand nothing in Rust/Tauri config referencedui/.Verification
tsc --noEmit+vite buildclean (validated by the new front-end CI job).Scope notes
ui/'spreview.jswas not ported (it wasn't part of the shipped React app).🤖 Generated with Claude Code