Skip to content

fix: on MCP install skip empty secrets#1503

Merged
ashlkv merged 1 commit intomainfrom
ashlkv/k8s-mcp
Dec 10, 2025
Merged

fix: on MCP install skip empty secrets#1503
ashlkv merged 1 commit intomainfrom
ashlkv/k8s-mcp

Conversation

@ashlkv
Copy link
Copy Markdown
Contributor

@ashlkv ashlkv commented Dec 10, 2025

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Vulnerabilities of archestra/platform:ci-test

📦 Image Reference archestra/platform:ci-test
digestsha256:4dd48c58b62099fbf0b6ce7814735584b1bf2606d75b88bc75be6d557363ba1b
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
platformlinux/amd64
size460 MB
packages1567
📦 Base Image node:24-alpine
also known as
  • 24-alpine3.22
  • 24.11-alpine
  • 24.11-alpine3.22
  • 24.11.1-alpine
  • 24.11.1-alpine3.22
  • krypton-alpine
  • krypton-alpine3.22
  • lts-alpine
  • lts-alpine3.22
digestsha256:d7a3af308e4006ba6d66bbae980fe39c118049b4a5eeaac8fa89e00944a2496b
vulnerabilitiescritical: 0 high: 1 medium: 1 low: 2

@github-actions
Copy link
Copy Markdown
Contributor

Recommended fixes for image archestra/platform:ci-test

Base image is node:24-alpine

Name24.11.1-alpine3.22
Digestsha256:d7a3af308e4006ba6d66bbae980fe39c118049b4a5eeaac8fa89e00944a2496b
Vulnerabilitiescritical: 0 high: 1 medium: 1 low: 2
Pushed3 weeks ago
Size56 MB
Packages217
Flavoralpine
OS3.22
Runtime24.11.1
The base image is also available under the supported tag(s): 24-alpine3.22, 24.11-alpine, 24.11-alpine3.22, 24.11.1-alpine, 24.11.1-alpine3.22, krypton-alpine, krypton-alpine3.22, lts-alpine, lts-alpine3.22

Refresh base image

Rebuild the image using a newer base image version. Updating this may result in breaking changes.
TagDetailsPushedVulnerabilities
24-alpine
Newer image for same tag
Also known as:
  • 24.11.1-alpine
  • 24.11.1-alpine3.23
  • 24.11-alpine
  • 24.11-alpine3.23
  • lts-alpine
  • lts-alpine3.23
  • 24-alpine3.23
  • krypton-alpine
  • krypton-alpine3.23
Benefits:
  • Same OS detected
  • Minor runtime version update
  • Newer image for same tag
  • Tag was pushed more recently
  • Image has similar size
  • Image introduces no new vulnerability but removes 2
  • Image contains equal number of packages
Image details:
  • Size: 56 MB
  • Flavor: alpine
  • OS: 3.23
  • Runtime: 24.11.1
5 days ago



Change base image

TagDetailsPushedVulnerabilities
25-alpine3.22
Major runtime version update
Also known as:
  • alpine3.22
  • 25.2.1-alpine3.22
  • 25.2-alpine3.22
Benefits:
  • Same OS detected
  • Image contains 1 fewer package
  • Major runtime version update
  • Tag was pushed more recently
  • Image has similar size
  • Image has same number of vulnerabilities
Image details:
  • Size: 57 MB
  • Flavor: alpine
  • OS: 3.22
  • Runtime: 25.2.1
3 weeks ago



slim
Tag is preferred tag
Also known as:
  • 25.2.1-slim
  • 25.2-slim
  • current-slim
  • 25-slim
  • bookworm-slim
  • 25-bookworm-slim
  • 25.2-bookworm-slim
  • 25.2.1-bookworm-slim
  • current-bookworm-slim
Benefits:
  • Tag is preferred tag
  • Tag was pushed more recently
  • Tag is using slim variant
  • slim was pulled 17K times last month
Image details:
  • Size: 77 MB
  • Runtime: 22
1 day ago



@github-actions
Copy link
Copy Markdown
Contributor

Overview

Image reference archestra/platform:latest archestra/platform:ci-test
- digest 548247944962 4dd48c58b620
- tag latest ci-test
- provenance 3bc6b5b
- vulnerabilities critical: 0 high: 0 medium: 0 low: 0 unspecified: 1 critical: 0 high: 0 medium: 0 low: 0 unspecified: 1
- platform linux/amd64 linux/amd64
- size 384 MB 460 MB (+76 MB)
- packages 1567 1567
Base Image node:24-alpine
also known as:
24-alpine3.22
24.11-alpine
24.11-alpine3.22
24.11.1-alpine
24.11.1-alpine3.22
krypton-alpine
krypton-alpine3.22
lts-alpine
lts-alpine3.22
node:24-alpine
also known as:
24-alpine3.22
24.11-alpine
24.11-alpine3.22
24.11.1-alpine
24.11.1-alpine3.22
krypton-alpine
krypton-alpine3.22
lts-alpine
lts-alpine3.22
- vulnerabilities critical: 0 high: 1 medium: 1 low: 2 critical: 0 high: 1 medium: 1 low: 2
Environment Variables (1 changes)
  • ± 1 changed
  • 14 unchanged
 ARCHESTRA_ANALYTICS=enabled
 ARCHESTRA_API_BASE_URL=http://localhost:9000
 ARCHESTRA_AUTH_DISABLE_BASIC_AUTH=false
 ARCHESTRA_AUTH_DISABLE_INVITATIONS=false
 ARCHESTRA_ENTERPRISE_LICENSE_ACTIVATED=false
 ARCHESTRA_ORCHESTRATOR_MCP_SERVER_BASE_IMAGE=europe-west1-docker.pkg.dev/friendly-path-465518-r6/archestra-public/mcp-server-base:0.0.3
 ARCHESTRA_SENTRY_ENVIRONMENT=
 ARCHESTRA_SENTRY_FRONTEND_DSN=
-ARCHESTRA_VERSION=0.6.27
+ARCHESTRA_VERSION=dev
 NEXT_TELEMETRY_DISABLED=1
 NODE_ENV=production
 NODE_VERSION=24.11.1
 PATH=/pnpm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
 PNPM_HOME=/pnpm
 YARN_VERSION=1.22.22

@ashlkv ashlkv marked this pull request as ready for review December 10, 2025 16:39
Copilot AI review requested due to automatic review settings December 10, 2025 16:39
@ashlkv ashlkv added this pull request to the merge queue Dec 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue during MCP server installation by skipping secret-type environment variables that have empty or whitespace-only values. Previously, the code would attempt to create Kubernetes secret references (secretKeyRef) for these empty secrets, which would cause problems since no actual K8s Secret resource would be created for them.

Key Changes

  • Added validation in createPodEnvFromConfig() to skip secret-type environment variables with empty or whitespace-only values before creating secretKeyRef entries in the pod specification

Comment thread platform/backend/src/mcp-server-runtime/k8s-pod.ts
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@ashlkv ashlkv added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 478dcfa Dec 10, 2025
28 checks passed
@ashlkv ashlkv deleted the ashlkv/k8s-mcp branch December 10, 2025 17:00
joeyorlando pushed a commit that referenced this pull request Dec 10, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.6.28](platform-v0.6.27...platform-v0.6.28)
(2025-12-10)


### Features

* vault - bring your own secret and credentials rework
([#1454](#1454))
([7399bf2](7399bf2))


### Bug Fixes

* address SSO role mapping not being invoked on subsequent logins
([#1506](#1506))
([6622edd](6622edd))
* on MCP install skip empty secrets
([#1503](#1503))
([478dcfa](478dcfa))


### Miscellaneous Chores

* update archestra catalog api codegen'd types
([c6f2218](c6f2218))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: archestra-ci[bot] <222894074+archestra-ci[bot]@users.noreply.github.com>
ashlkv added a commit that referenced this pull request Dec 17, 2025
ashlkv pushed a commit that referenced this pull request Dec 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.6.28](platform-v0.6.27...platform-v0.6.28)
(2025-12-10)


### Features

* vault - bring your own secret and credentials rework
([#1454](#1454))
([7399bf2](7399bf2))


### Bug Fixes

* address SSO role mapping not being invoked on subsequent logins
([#1506](#1506))
([6622edd](6622edd))
* on MCP install skip empty secrets
([#1503](#1503))
([478dcfa](478dcfa))


### Miscellaneous Chores

* update archestra catalog api codegen'd types
([c6f2218](c6f2218))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: archestra-ci[bot] <222894074+archestra-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants