Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate protobuf files under user #371

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zanicar
Copy link
Contributor

@zanicar zanicar commented May 10, 2023

Ensures that generated protobuf files belong to USER and not root

@zanicar zanicar marked this pull request as ready for review May 10, 2023 14:46
@zanicar zanicar requested a review from a team as a code owner May 10, 2023 14:46
@zanicar zanicar requested a review from spoo-bar May 10, 2023 14:46
@zanicar
Copy link
Contributor Author

zanicar commented May 11, 2023

fixes: #358

@zanicar
Copy link
Contributor Author

zanicar commented Aug 23, 2023

The updated script fails in WSL environments... would those using Windows Subsystem for Linux please test and provide feedback / recommendations regarding this issue as I am not able to reproduce the issue as a Linux user.

I suspect it has to do with how the Docker CLI uses environment variables; It looks like the default environment gets completely overridden when passing additional variables via Docker CLI. Would be very grateful if somebody could investigate and verify the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants