Skip to content

PE-2806: track the partial changes of canceled runs as well#68

Open
matibat wants to merge 9 commits into
devfrom
PE-2771_leftover
Open

PE-2806: track the partial changes of canceled runs as well#68
matibat wants to merge 9 commits into
devfrom
PE-2771_leftover

Conversation

@matibat

@matibat matibat commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

Now, on each block iteration the output is persisted. Then at the end of the "Run" (the aggregation script) Job, the last persisted output is published to the Inferno Stats drive (only if there was changes, won't do if not), even if the action was stopped or if there was a memory overflow.

Changes

  • Writes to disk the changes on every new iterated block
  • Makes the GH Action to:
    • duplicate the initial daily_output JSON to be later compared;
    • after the command is stopped (either failed or succeed), conditionally upload the output if there was changes

@matibat matibat requested a review from karlprieb December 17, 2022 01:37
@matibat matibat self-assigned this Dec 17, 2022

@matibat matibat left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

Comment thread .github/workflows/aggregate.yaml Outdated
Comment thread src/daily_output.ts Outdated
Comment thread src/daily_output.ts Outdated
Comment thread src/queries.ts
@matibat matibat marked this pull request as ready for review January 4, 2023 15:07
@matibat matibat changed the title PE-2771: track the partial changes of canceled runs as well PE-2806: track the partial changes of canceled runs as well Jan 4, 2023
echo "::set-env name=OUTPUT_HAS_CHANGED::$IS_THERE_DIFF" // vs. export OUTPUT_HAS_CHANGED="$IS_THERE_DIFF" (?)

- name: Publish output
if: ${{ env.OUTPUT_HAS_CHANGED == 'true' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition!

@matibat matibat requested a review from karlprieb January 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants