Fix CI #140
Open
Fix CI #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Compile MuxTo github action fails (e.g., https://github.com/arduino/ArduinoCore-megaavr/actions/runs/11121101633), so we cannot follow #103 (comment).
This PR tries to fix that situation.
upload-artifact@v2anddownload-artifact@v2failed because they are deprecated, so this PR upgrades them to the latest version (v4). The deprecation notice is here: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/upload-artifact@v4requires artifact names to be unique, so this PR fixes them(cf. Conflict: an artifact with this name already exists on the workflow run simonw/shot-scraper#141)
MattairTech_Arduino:samdfailed because the link to its json (https://www.mattairtech.com/software/arduino/package_MattairTech_index.json) is broken. We have its archive (https://web.archive.org/web/20210308115824/https://www.mattairtech.com/software/arduino/package_MattairTech_index.json), but some of the indicated URLs (e.g., https://www.mattairtech.com/software/arduino/MattairTech_samd_1.6.5-mt1.zip) are not archived:http://web.archive.org/web/*/https://www.mattairtech.com/software/arduino/*
so we cannot install
MattairTech_Arduino:samdvia the archived json.This PR avoids that problem by installing Fab_SAM_Arduino:samd, the successor of
MattairTech_Arduino:samd. This workaround requires some patches to ArduinoCore-samd, so I'm not sure this is a good way.