refactor: Use callback instead of channels #176
Merged
+139
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cmaglie
force-pushed
the
update-dont-use-iterators
branch
2 times, most recently
from
d954a1a to
ba3af71
Compare
cmaglie
force-pushed
the
update-dont-use-iterators
branch
from
ba3af71 to
49bfbc5
Compare
It is already broadcasted by the caller.
lucarin91
approved these changes
Dec 24, 2025
| // It publishes events to subscribers during the upgrade process. | ||
| // It returns an error if the upgrade is already in progress or if the upgrade command fails. | ||
| func (s *Service) UpgradePackages(ctx context.Context, names []string) (<-chan update.Event, error) { | ||
| func (s *Service) UpgradePackages(ctx context.Context, names []string, eventCB func(update.Event)) error { |
Contributor
There was a problem hiding this comment.
I would define a type for the call back
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use callbacks on synchronous functions instead of the more complicated channels.
It also makes error handling more straightforward.
Change description
Additional Notes
Supersedes #91
Reviewer checklist
main.