-
Notifications
You must be signed in to change notification settings - Fork 4
fix: check free disk space and allow to specify a different download/extraction directory #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
previously requested changes
Nov 3, 2025
Co-authored-by: Per Tillisch <[email protected]>
Requested changes have been made. Thanks!
lucarin91
reviewed
Nov 5, 2025
Co-authored-by: Luca Rinaldi <[email protected]>
Co-authored-by: Luca Rinaldi <[email protected]>
lucarin91
reviewed
Nov 11, 2025
lucarin91
approved these changes
Nov 14, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the urgent need for this feature, I think we should merge the PR in its current state, but I would suggest executing a refactoring of the code to make it more maintainable #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default download/extraction directory might be on a disk with insufficient space.
Change description
Two changes have been introduced:
--temp-dirflag;Additional Notes
Reviewer checklist
main.