Skip to content

Rpm builds for ARM64 and x64 linux #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
67 changes: 32 additions & 35 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: Arduino IDE

on:
create:
push:
@@ -16,7 +15,7 @@ on:
- 'static/**'
- '*.md'
tags:
- '[0-9]+.[0-9]+.[0-9]+*'
- '[0-9]+.[0-9]+.[0-9]+*'
workflow_dispatch:
inputs:
paid-runners:
@@ -101,6 +100,8 @@ env:
name: Linux_X86-64_zip
- path: '*Linux_64bit.AppImage'
name: Linux_X86-64_app_image
- path: '*Linux_64bit.rpm'
name: Linux_X86-64_rpm
- config:
name: macOS x86
runs-on: macos-13
@@ -133,11 +134,24 @@ env:
name: macOS_arm64_dmg
- path: '*macOS_arm64.zip'
name: macOS_arm64_zip
- config:
name: ARM Ubuntu 22.04
runs-on: ubuntu-22.04-arm
container: |
null
job-transfer-artifact-suffix: ARM_64bit
mergeable-channel-file: 'true'
artifacts:
- path: '*Linux_arm64.zip'
name: Linux_arm64_zip
- path: '*Linux_arm64.AppImage'
name: Linux_arm64_app_image
- path: '*Linux_arm64.rpm'
name: Linux_arm64_rpm
PAID_RUNNER_BUILD_DATA: |
# This system was implemented to allow selective use of paid GitHub-hosted runners, due to the Apple Silicon runner
# incurring a charge at that time. Free Apple Silicon runners are now available so the configuration was moved to
# `BASE_BUILD_DATA`, but the system was left in place for future use.

jobs:
run-determination:
runs-on: ubuntu-latest
@@ -160,9 +174,7 @@ jobs:
# There is no need to run the other jobs.
RESULT="false"
fi

echo "result=$RESULT" >> $GITHUB_OUTPUT

build-type-determination:
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
@@ -199,13 +211,11 @@ jobs:
is_nightly="false"
channel_name="nightly"
fi

echo "is-release=$is_release" >> $GITHUB_OUTPUT
echo "is-nightly=$is_nightly" >> $GITHUB_OUTPUT
echo "channel-name=$channel_name" >> $GITHUB_OUTPUT
# Only attempt upload to Amazon S3 if the credentials are available.
echo "publish-to-s3=${{ secrets.AWS_ROLE_ARN != '' }}" >> $GITHUB_OUTPUT

select-targets:
needs: build-type-determination
runs-on: ubuntu-latest
@@ -232,7 +242,6 @@ jobs:
--output-format json \
'[.[].config]'
)"

artifact_matrix="$(
(
echo "${{ env.BASE_BUILD_DATA }}";
@@ -242,43 +251,35 @@ jobs:
--output-format json \
'map(.artifacts[] + (.config | pick(["job-transfer-artifact-suffix"])))'
)"

# The build matrix produces two macOS jobs (x86 and ARM) so the "channel update info files"
# generated by each must be merged.
merge_channel_files="true"

else
build_matrix="$(
echo "${{ env.BASE_BUILD_DATA }}" | \
yq \
--output-format json \
'[.[].config]'
)"

artifact_matrix="$(
echo "${{ env.BASE_BUILD_DATA }}" | \
yq \
--output-format json \
'map(.artifacts[] + (.config | pick(["job-transfer-artifact-suffix"])))'
)"

merge_channel_files="false"
fi

# Set workflow step outputs.
# See: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
delimiter="$RANDOM"
echo "build-matrix<<$delimiter" >> $GITHUB_OUTPUT
echo "$build_matrix" >> $GITHUB_OUTPUT
echo "$delimiter" >> $GITHUB_OUTPUT

delimiter="$RANDOM"
echo "artifact-matrix<<$delimiter" >> $GITHUB_OUTPUT
echo "$artifact_matrix" >> $GITHUB_OUTPUT
echo "$delimiter" >> $GITHUB_OUTPUT

echo "merge-channel-files=$merge_channel_files" >> $GITHUB_OUTPUT

build:
name: build (${{ matrix.config.name }})
needs:
@@ -290,7 +291,7 @@ jobs:
# to skip passing signing credentials to electron-builder
IS_WINDOWS_CONFIG: ${{ matrix.config.name == 'Windows' }}
INSTALLER_CERT_WINDOWS_CER: "/tmp/cert.cer"
# We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
# We are hardcoding the path for signtool because it is not present on the Windows PATH env var by default.
# Keep in mind that this path could change when upgrading to a new runner version
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
WIN_CERT_PASSWORD: ${{ secrets[matrix.config.certificate-password-secret] }}
@@ -310,16 +311,28 @@ jobs:
timeout-minutes: 90

steps:
- name: Install Chromium and ensure fpm works (ARM only)
if: matrix.config.name == 'ARM Ubuntu 22.04'
run: |
sudo apt-get update
sudo apt-get install -y chromium-browser ruby ruby-dev
sudo gem install fpm
echo "USE_SYSTEM_FPM=true" >> $GITHUB_ENV
- name: Install RPM Build Tools (Linux only)
if: runner.os == 'Linux'
run: |
apt update && apt install sudo
sudo apt-get update
sudo apt-get install -y rpm

- name: Symlink custom working directory
shell: cmd
if: runner.os == 'Windows' && matrix.config.working-directory
run: |
if not exist "${{ matrix.config.working-directory }}" mklink /d "${{ matrix.config.working-directory }}" "C:\actions-runner\_work\arduino-ide\arduino-ide"

- name: Checkout
uses: actions/checkout@v4


- name: Install Node.js
if: runner.name != 'WINDOWS-SIGN-PC'
uses: actions/setup-node@v4
@@ -337,7 +350,6 @@ jobs:
install \
--global \
"yarn@${{ env.YARN_VERSION }}"

- name: Install Python 3.x
if: fromJSON(matrix.config.container) == null && runner.name != 'WINDOWS-SIGN-PC'
uses: actions/setup-python@v5
@@ -377,15 +389,12 @@ jobs:
export CSC_KEY_PASSWORD="${{ secrets[matrix.config.certificate-password-secret] }}"
export CSC_FOR_PULL_REQUEST=true
fi

npx node-gyp install
yarn install

yarn --cwd arduino-ide-extension build
yarn --cwd electron-app rebuild
yarn --cwd electron-app build
yarn --cwd electron-app package

# Both macOS jobs generate a "channel update info file" with same path and name. The second job to complete would
# overwrite the file generated by the first in the workflow artifact.
- name: Stage channel file for merge
@@ -399,11 +408,9 @@ jobs:
mv \
"${{ env.BUILD_ARTIFACTS_PATH }}/${{ needs.build-type-determination.outputs.channel-name }}-mac.yml" \
"${staged_channel_files_path}/${{ needs.build-type-determination.outputs.channel-name }}-mac-${{ runner.arch }}.yml"

# Set workflow environment variable for use in other steps.
# See: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
echo "STAGED_CHANNEL_FILES_PATH=$staged_channel_files_path" >> "$GITHUB_ENV"

- name: Upload staged-for-merge channel file artifact
uses: actions/upload-artifact@v4
if: >
@@ -425,7 +432,6 @@ jobs:
shell: cmd
run: |
rmdir /s /q "${{ matrix.config.working-directory }}\${{ env.BUILD_ARTIFACTS_PATH }}"

merge-channel-files:
needs:
- build-type-determination
@@ -439,7 +445,6 @@ jobs:
run: |
# See: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
echo "CHANNEL_FILES_PATH=${{ runner.temp }}/channel-files" >> "$GITHUB_ENV"

- name: Checkout
uses: actions/checkout@v4

@@ -478,7 +483,6 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y libx11-dev libxkbfile-dev libsecret-1-dev

- name: Install dependencies
run: yarn

@@ -488,7 +492,6 @@ jobs:
./scripts/merge-channel-files.js \
--channel "${{ needs.build-type-determination.outputs.channel-name }}" \
--input "${{ env.CHANNEL_FILES_PATH }}"

- name: Upload merged channel files job transfer artifact
uses: actions/upload-artifact@v4
with:
@@ -555,16 +558,13 @@ jobs:
fi
fi
echo -e "$BODY"

# Set workflow step output
# See: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings
DELIMITER="$RANDOM"
echo "BODY<<$DELIMITER" >> $GITHUB_OUTPUT
echo "$BODY" >> $GITHUB_OUTPUT
echo "$DELIMITER" >> $GITHUB_OUTPUT

echo "$BODY" > CHANGELOG.txt

- name: Upload changelog job transfer artifact
if: needs.build-type-determination.outputs.is-nightly == 'true'
uses: actions/upload-artifact@v4
@@ -615,7 +615,6 @@ jobs:
- name: Publish Nightly [S3]
run: |
aws s3 sync ${{ env.ARTIFACTS_FOLDER }} s3://${{ secrets.DOWNLOADS_BUCKET }}/arduino-ide/nightly

release:
needs:
- build-type-determination
@@ -653,7 +652,6 @@ jobs:
id: tag_name
run: |
echo "TAG_NAME=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT

- name: Publish Release [GitHub]
uses: svenstaro/[email protected]
with:
@@ -675,7 +673,6 @@ jobs:
if: needs.build-type-determination.outputs.publish-to-s3 == 'true'
run: |
aws s3 sync ${{ env.ARTIFACTS_FOLDER }} s3://${{ secrets.DOWNLOADS_BUCKET }}/arduino-ide

clean:
# This job must run after all jobs that use the transfer artifact.
needs:
1 change: 1 addition & 0 deletions .github/workflows/test-javascript.yml
Original file line number Diff line number Diff line change
@@ -79,6 +79,7 @@ jobs:
- macos-latest
- ubuntu-latest
- windows-latest
- ubuntu-22.04-arm

steps:
- name: Checkout
6 changes: 4 additions & 2 deletions electron-app/package.json
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"version": "2.3.7",
"license": "AGPL-3.0-or-later",
"main": "./src-gen/backend/electron-main.js",
"homepage": "https://arduino.cc/en/software",
"dependencies": {
"@theia/core": "1.57.0",
"@theia/debug": "1.57.0",
@@ -102,7 +103,7 @@
}
}
},
"author": "Arduino SA",
"author": "Arduino SA (https://arduino.cc/) <[email protected]>",
"description": "Arduino IDE",
"build": {
"appId": "cc.arduino.IDE2",
@@ -154,7 +155,8 @@
"linux": {
"target": [
"zip",
"AppImage"
"AppImage",
"rpm"
],
"category": "Development",
"icon": "resources/icons"
2 changes: 1 addition & 1 deletion electron-app/scripts/post-package.js
Original file line number Diff line number Diff line change
@@ -131,7 +131,7 @@ async function copyFilesToBuildArtifacts() {
case 'linux': {
filesToCopy.push(
...glob
.sync('**/arduino-ide*.{zip,AppImage}', { cwd })
.sync('**/arduino-ide*.{zip,AppImage,rpm}', { cwd })
.map((p) => path.join(cwd, p))
);
break;

Unchanged files with check annotations Beta

'arduino/board/succesfullyUninstalledPlatform',
'Successfully uninstalled platform {0}:{1}',
item.name,
item.installedVersion!

Check warning on line 86 in arduino-ide-extension/src/browser/boards/boards-list-widget.ts

GitHub Actions / check

Forbidden non-null assertion
),
{ timeout: 3000 }
);
unregisterSubmenu(menuPath, this.menuRegistry)
),
...Array.from(commands.keys()).map((commandId, i) => {
const { label } = commands.get(commandId)!;

Check warning on line 115 in arduino-ide-extension/src/browser/contributions/boards-data-menu-updater.ts

GitHub Actions / check

Forbidden non-null assertion
this.menuRegistry.registerMenuAction(menuPath, {
commandId,
order: String(i).padStart(4),
return undefined;
}
protected async run(commandId: string): Promise<any> {

Check warning on line 229 in arduino-ide-extension/src/browser/contributions/edit-contributions.ts

GitHub Actions / check

Unexpected any. Specify a different type
const editor = await this.current();
if (editor) {
const action = editor.getAction(commandId);
fqbn,
});
if (user.length) {
(user as any).unshift(

Check warning on line 329 in arduino-ide-extension/src/browser/contributions/examples.ts

GitHub Actions / check

Unexpected any. Specify a different type
nls.localize(
'arduino/examples/customLibrary',
'Examples from Custom Libraries'
);
}
if (name && fqbn && current.length) {
(current as any).unshift(

Check warning on line 337 in arduino-ide-extension/src/browser/contributions/examples.ts

GitHub Actions / check

Unexpected any. Specify a different type
nls.localize('arduino/examples/for', 'Examples for {0}', name)
);
}
if (any.length) {
(any as any).unshift(

Check warning on line 342 in arduino-ide-extension/src/browser/contributions/examples.ts

GitHub Actions / check

Unexpected any. Specify a different type
nls.localize('arduino/examples/forAny', 'Examples for any board')
);
}
const userMenuPath = [...includeLibMenuPath, '3_contributed'];
const { user, rest } = LibraryPackage.groupByLocation(libraries);
if (rest.length) {
(rest as any).unshift(

Check warning on line 114 in arduino-ide-extension/src/browser/contributions/include-library.ts

GitHub Actions / check

Unexpected any. Specify a different type
nls.localize('arduino/library/arduinoLibraries', 'Arduino libraries')
);
}
if (user.length) {
(user as any).unshift(

Check warning on line 119 in arduino-ide-extension/src/browser/contributions/include-library.ts

GitHub Actions / check

Unexpected any. Specify a different type
nls.localize(
'arduino/library/contributedLibraries',
'Contributed libraries'
});
registry.registerCommand(UploadCertificate.Commands.OPEN_CERT_CONTEXT, {
execute: async (args: any) => {

Check warning on line 86 in arduino-ide-extension/src/browser/contributions/upload-certificate.ts

GitHub Actions / check

Unexpected any. Specify a different type
this.contextMenuRenderer.render({
menuPath: ArduinoMenus.ROOT_CERTIFICATES__CONTEXT,
anchor: {
});
}
watch(uri: URI, opts: WatchOptions): Disposable {

Check warning on line 79 in arduino-ide-extension/src/browser/create/create-fs-provider.ts

GitHub Actions / check

'uri' is defined but never used. Allowed unused args must match /^_/u
return Disposable.NULL;
}