Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2025

Bumps actions/setup-go from 5 to 6.

Release notes

Sourced from actions/setup-go's releases.

v6.0.0

What's Changed

Breaking Changes

Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. See Release Notes

Dependency Upgrades

New Contributors

Full Changelog: actions/setup-go@v5...v6.0.0

v5.5.0

What's Changed

Bug fixes:

Dependency updates:

New Contributors

Full Changelog: actions/setup-go@v5...v5.5.0

v5.4.0

What's Changed

Dependency updates :

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Sep 4, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this causes a regression:

https://github.com/arduino/arduino-language-server/actions/runs/17465951422/job/49662588633?pr=212#step:5:1

Modernize usages of outdated APIs
Run task go:fix
  task go:fix
  shell: /usr/bin/bash -e {0}
  env:
    GO_VERSION: 1.22.0
    GOTOOLCHAIN: local
    GO_MODULE_PATH: ./
task: [go:fix] go fix github.com/arduino/arduino-language-server github.com/arduino/arduino-language-server/globals github.com/arduino/arduino-language-server/ls github.com/arduino/arduino-language-server/sourcemapper github.com/arduino/arduino-language-server/streams github.com/arduino/arduino-language-server/version
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
invalid -go=go1.22.0
exit status 2
task: Failed to run task "go:fix": exit status 1

The fault does not occur in the workflow runs using actions/setup-go@v5.

I notice that the GOTOOLCHAIN environment variable is not defined by that version of the action:

https://github.com/arduino/arduino-language-server/actions/runs/17485157349/job/49662673720#step:5:1

Modernize usages of outdated APIs
Run task go:fix
  task go:fix
  shell: /usr/bin/bash -e {0}
  env:
    GO_VERSION: 1.22.0
    GO_MODULE_PATH: ./
task: [go:fix] go fix github.com/arduino/arduino-language-server github.com/arduino/arduino-language-server/globals github.com/arduino/arduino-language-server/ls github.com/arduino/arduino-language-server/sourcemapper github.com/arduino/arduino-language-server/streams github.com/arduino/arduino-language-server/version

So I'll put this on hold for now. Hopefully a fix will be made in the actions/setup-go action. Otherwise we'll need to make time to investigate and find a fix (perhaps working around it by bumping the project Go version?).

@per1234 per1234 added type: enhancement Proposed improvement status: on hold Do not proceed at this time labels Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant