Implemented flow-control on message forwarder. #18
+109
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a placeholder on the msgpackrouter constructor to specify the desired queue size (it will be implemented later).
cmaglie
force-pushed
the
forwarder-flow-control
branch
from
9dd1255 to
d0c942d
Compare
martacarbone
approved these changes
Dec 15, 2025
dido18
reviewed
Dec 16, 2025
Contributor
dido18
left a comment
dido18
left a comment
There was a problem hiding this comment.
I would document the semantic meaning of Maxworker=0
In the current implementation, it means no worker limit: every call to startWorker spawns a new goroutine (i.e., "disable worker pool.")
Member
Author
Ok, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #15
Change description
This change mainly affects the
msgpackrpclibrary, where the read-loop runs and spawns "worker" goroutines.To effectively pause reading from a client, we need to limit the number of parallel workers for each client, and this is what this PR does.
Additional Notes
Reviewer checklist
main.