Skip to content

Bump golangci/golangci-lint-action from 3 to 8 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-go-task.yml
Original file line number Diff line number Diff line change
@@ -123,7 +123,7 @@ jobs:
version: 3.x

- name: Install golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v8
with:
version: v1.64.7


Unchanged files with check annotations Beta

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/release-go-task/DistTasks.yml

Check warning on line 1 in DistTasks.yml

GitHub Actions / Generate problem matcher output

1:121 [line-length] line too long (125 > 120 characters)

Check warning on line 1 in DistTasks.yml

GitHub Actions / Generate problem matcher output

1:121 [line-length] line too long (125 > 120 characters)
version: "3"
# This taskfile is ideally meant to be project agnostic and could be dropped in
desc: Builds Mac OS X 64 bit binaries
dir: "{{.DIST_DIR}}"
cmds:
# "git config safe.directory" is required until this is fixed https://github.com/elastic/golang-crossbuild/issues/232

Check warning on line 235 in DistTasks.yml

GitHub Actions / Generate problem matcher output

235:121 [line-length] line too long (123 > 120 characters)

Check warning on line 235 in DistTasks.yml

GitHub Actions / Generate problem matcher output

235:121 [line-length] line too long (123 > 120 characters)
- |
mkdir {{.PLATFORM_DIR}}
cp ../LICENSE.txt {{.PLATFORM_DIR}}/
desc: Builds Mac OS X ARM64 binaries
dir: "{{.DIST_DIR}}"
cmds:
# "git config safe.directory" is required until this is fixed https://github.com/elastic/golang-crossbuild/issues/232

Check warning on line 272 in DistTasks.yml

GitHub Actions / Generate problem matcher output

272:121 [line-length] line too long (123 > 120 characters)

Check warning on line 272 in DistTasks.yml

GitHub Actions / Generate problem matcher output

272:121 [line-length] line too long (123 > 120 characters)
- |
mkdir {{.PLATFORM_DIR}}
cp ../LICENSE.txt {{.PLATFORM_DIR}}/
apps:
- source_path: ./
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-dependencies/GPL-3.0/.licensed.yml

Check warning on line 8 in .licensed.yml

GitHub Actions / Generate problem matcher output

8:121 [line-length] line too long (136 > 120 characters)

Check warning on line 8 in .licensed.yml

GitHub Actions / Generate problem matcher output

8:121 [line-length] line too long (136 > 120 characters)
allowed:
# The following are based on: https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
- gpl-1.0-or-later
sh: echo "$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
TIMESTAMP_SHORT:
sh: echo "{{now | date "20060102"}}"
VERSION: "{{if .NIGHTLY}}nightly-{{.TIMESTAMP_SHORT}}{{else if .TAG}}{{.TAG}}{{else}}{{.PACKAGE_NAME_PREFIX}}git-snapshot{{end}}"

Check warning on line 27 in Taskfile.yml

GitHub Actions / Generate problem matcher output

27:121 [line-length] line too long (131 > 120 characters)

Check warning on line 27 in Taskfile.yml

GitHub Actions / Generate problem matcher output

27:121 [line-length] line too long (131 > 120 characters)
CONFIGURATION_PACKAGE: github.com/arduino/serial-monitor/version
LDFLAGS: >
-ldflags
cmds:
- go build -v {{.LDFLAGS}}
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 45 in Taskfile.yml

GitHub Actions / Generate problem matcher output

45:121 [line-length] line too long (126 > 120 characters)

Check warning on line 45 in Taskfile.yml

GitHub Actions / Generate problem matcher output

45:121 [line-length] line too long (126 > 120 characters)
go:fix:
desc: Modernize usages of outdated APIs
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
cmds:
- go fix {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 52 in Taskfile.yml

GitHub Actions / Generate problem matcher output

52:121 [line-length] line too long (124 > 120 characters)

Check warning on line 52 in Taskfile.yml

GitHub Actions / Generate problem matcher output

52:121 [line-length] line too long (124 > 120 characters)
go:format:
desc: Format Go code
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
cmds:
- go fmt {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml

Check warning on line 59 in Taskfile.yml

GitHub Actions / Generate problem matcher output

59:121 [line-length] line too long (124 > 120 characters)

Check warning on line 59 in Taskfile.yml

GitHub Actions / Generate problem matcher output

59:121 [line-length] line too long (124 > 120 characters)
go:lint:
desc: Lint Go code
dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
fi
- golangci-lint run
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-prettier-formatting-task/Taskfile.yml

Check warning on line 72 in Taskfile.yml

GitHub Actions / Generate problem matcher output

72:121 [line-length] line too long (141 > 120 characters)

Check warning on line 72 in Taskfile.yml

GitHub Actions / Generate problem matcher output

72:121 [line-length] line too long (141 > 120 characters)
general:format-prettier:
desc: Format all supported files with Prettier
deps:
cmds:
- npx prettier --write .
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/poetry-task/Taskfile.yml

Check warning on line 80 in Taskfile.yml

GitHub Actions / Generate problem matcher output

80:121 [line-length] line too long (122 > 120 characters)

Check warning on line 80 in Taskfile.yml

GitHub Actions / Generate problem matcher output

80:121 [line-length] line too long (122 > 120 characters)
poetry:install-deps:
desc: Install dependencies managed by Poetry
cmds: