Open
Conversation
This was introduced in commit 81138d5 and realesed with version R2-7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some Andor camera models, such as the iDus, might not have a vertical dimension, reading out only a line array. For these cameras trying to read and write the Vertical Shift Speed (
VSSpeed) would not work.This parameter is initialized during start up, using the
check_status()mechanism (throwing an exception if the SDK does not report success) which prevents the further code from being properly executed, leaving the camera in a not working condition:Background
This behavior was introduced in version R2-7, with commit: 81138d5.
A very similar change, but for the vertical shift amplitude (VSAmplitude) created a similar issue as described in #49 and which was fixed with #50
Code Adjustments
Interaction with the
VSSpeedhappens on multiple locations. Unfortunately, different to theVSAmplitudecase, the availability ofVSSpeedcannot be determined by looking at themCapabilitiesreadout from the camera, which makes the fix slightly more complex. The idea is basically to do the same as thecheck_status()function, but avoid throwing an exception and continuing gracefully.Unrelated change
The first commit of this PR is an unrelated change, fixing an section of the code which was using Windows-style line endings, which is nowadays with modern editors and Git settings quite difficult to properly identify and/or is fixed "automatically". I only noticed that while trying to set up the PR, as it was not even shown to me locally as a change.
Tests
Additional Comments unrelated to this PR
2.102.30034.0and have not seen major issues, other than andorCCD:dataTask:, Data thread is running but main thread thinks we are not acquiring. #51 and one small other issueAI Disclaimer
I am not an experienced c++ developer and have used AI tools helping me to understand certain sections of the code and let the AI suggest possible solutions. While I have not used any of the suggestions in the end, my changes might be influenced by the suggestions.