Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS5837 console calibration options and code cleanup #22466

Merged
merged 14 commits into from
Nov 11, 2024

Conversation

vtHydroponics
Copy link
Contributor

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241030
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@vtHydroponics
Copy link
Contributor Author

A question for the MS5837 calibration via the console... I need a value to be persistently stored for the pressure offset to be retained between resets. Automatic recalibration of the pressure offset would not be possible due to the requirement of both sensors to be at the same elevation for calibration. Thank you.

@arendst
Copy link
Owner

arendst commented Nov 11, 2024

What's the size of the value (uint8_t, uint16_t, uint32_t, int) - keep it as small as possible?

@arendst
Copy link
Owner

arendst commented Nov 11, 2024

Chks fail due to my error. Fixing now.

@arendst arendst merged commit caa63f4 into arendst:development Nov 11, 2024
26 of 59 checks passed
@vtHydroponics
Copy link
Contributor Author

the size of the value is a 4 byte float

arendst added a commit that referenced this pull request Nov 11, 2024
@arendst
Copy link
Owner

arendst commented Nov 11, 2024

Use variable Settings->ms5837_pressure_offset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants