Add HP OMEN Transcend 16 8C4D fan support#20
Open
LauriSarap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this on an HP OMEN Transcend 16 with board ID
8C4D. The board was already listed as a possible OMEN board, but the legacy OMEN profile path did not actually change fan speed for me.Using the Victus S fan-control path with
omen_v1_thermal_paramsdoes work: the driver exposes the hwmon PWM controls, and writing fan values changes the real fan RPM. This PR moves8C4Dfrom the possible board list to the supported board list and adds it to the same thermal-parameter table.Tested by:
hp-wmi.koagainst Arch Linux 6.18 LTS headers