Update examples using ResourceRequirements

Signed-off-by: Elliot Gunton <[email protected]>
argoproj-labs · Dec 12, 2024 · 88e7b68 · 88e7b68
1 parent d0dbcda
commit 88e7b68
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/docs/examples/workflows/misc/user_container.md b/docs/examples/workflows/misc/user_container.md
@@ -34,7 +34,7 @@ This example showcases the user of a user container with a volume mount.
                 metadata=m.ObjectMeta(name="something"),
                 spec=m.PersistentVolumeClaimSpec(
                     access_modes=["ReadWriteOnce"],
-                    resources=m.ResourceRequirements(requests={"storage": "64Mi"}),
+                    resources=m.VolumeResourceRequirements(requests={"storage": "64Mi"}),
                 ),
             )
         ],

diff --git a/docs/examples/workflows/upstream/ci_output_artifact.md b/docs/examples/workflows/upstream/ci_output_artifact.md
@@ -30,7 +30,7 @@ The upstream example can be [found here](https://github.com/argoproj/argo-workfl
                 metadata=m.ObjectMeta(name="workdir"),
                 spec=m.PersistentVolumeClaimSpec(
                     access_modes=["ReadWriteOnce"],
-                    resources=m.ResourceRequirements(
+                    resources=m.VolumeResourceRequirements(
                         requests={
                             "storage": m.Quantity(__root__="1Gi"),
                         }

diff --git a/docs/examples/workflows/upstream/ci_workflowtemplate.md b/docs/examples/workflows/upstream/ci_workflowtemplate.md
@@ -34,7 +34,7 @@ The upstream example can be [found here](https://github.com/argoproj/argo-workfl
                 metadata=m.ObjectMeta(name="work"),
                 spec=m.PersistentVolumeClaimSpec(
                     access_modes=["ReadWriteOnce"],
-                    resources=m.ResourceRequirements(
+                    resources=m.VolumeResourceRequirements(
                         requests={
                             "storage": m.Quantity(__root__="64Mi"),
                         }

diff --git a/docs/examples/workflows/use-cases/fine_tune_llama.md b/docs/examples/workflows/use-cases/fine_tune_llama.md
@@ -260,7 +260,7 @@ There are several implicit dependencies in this script:
             m.PersistentVolumeClaim(
                 metadata=m.ObjectMeta(name=f"rank-{i}"),
                 spec=m.PersistentVolumeClaimSpec(
-                    resources=m.ResourceRequirements(requests={"storage": "20Gi"}, limits={"storage": "20Gi"}),
+                    resources=m.VolumeResourceRequirements(requests={"storage": "20Gi"}, limits={"storage": "20Gi"}),
                     # TODO: it's possible to spin up pods in one zone of a region and a disk in another zone of a region!
                     #       I recommend setting a `storage_class_name` that specifically tells K8s that it should create
                     #       the volumes only when pods actually want to _mount_ a volume! That way the disks are

diff --git a/examples/workflows/misc/user_container.py b/examples/workflows/misc/user_container.py
@@ -26,7 +26,7 @@ def foo():
             metadata=m.ObjectMeta(name="something"),
             spec=m.PersistentVolumeClaimSpec(
                 access_modes=["ReadWriteOnce"],
-                resources=m.ResourceRequirements(requests={"storage": "64Mi"}),
+                resources=m.VolumeResourceRequirements(requests={"storage": "64Mi"}),
             ),
         )
     ],

diff --git a/examples/workflows/upstream/ci_output_artifact.py b/examples/workflows/upstream/ci_output_artifact.py
@@ -17,7 +17,7 @@
             metadata=m.ObjectMeta(name="workdir"),
             spec=m.PersistentVolumeClaimSpec(
                 access_modes=["ReadWriteOnce"],
-                resources=m.ResourceRequirements(
+                resources=m.VolumeResourceRequirements(
                     requests={
                         "storage": m.Quantity(__root__="1Gi"),
                     }

diff --git a/examples/workflows/upstream/ci_workflowtemplate.py b/examples/workflows/upstream/ci_workflowtemplate.py
@@ -21,7 +21,7 @@
             metadata=m.ObjectMeta(name="work"),
             spec=m.PersistentVolumeClaimSpec(
                 access_modes=["ReadWriteOnce"],
-                resources=m.ResourceRequirements(
+                resources=m.VolumeResourceRequirements(
                     requests={
                         "storage": m.Quantity(__root__="64Mi"),
                     }

diff --git a/examples/workflows/use_cases/fine_tune_llama.py b/examples/workflows/use_cases/fine_tune_llama.py
@@ -253,7 +253,7 @@
         m.PersistentVolumeClaim(
             metadata=m.ObjectMeta(name=f"rank-{i}"),
             spec=m.PersistentVolumeClaimSpec(
-                resources=m.ResourceRequirements(requests={"storage": "20Gi"}, limits={"storage": "20Gi"}),
+                resources=m.VolumeResourceRequirements(requests={"storage": "20Gi"}, limits={"storage": "20Gi"}),
                 # TODO: it's possible to spin up pods in one zone of a region and a disk in another zone of a region!
                 #       I recommend setting a `storage_class_name` that specifically tells K8s that it should create
                 #       the volumes only when pods actually want to _mount_ a volume! That way the disks are