Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Elliot Gunton <[email protected]>
Signed-off-by: DanCardin <[email protected]>
  • Loading branch information
DanCardin and elliotgunton authored Dec 19, 2023
1 parent eab769b commit b51d164
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cicd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
file: ./coverage.xml

test-cli:
name: test py${{ matrix.python-version }} (pydantic v1) on ${{ matrix.os }}
name: test cli with py${{ matrix.python-version }} (pydantic v1) on ${{ matrix.os }}
timeout-minutes: 10
strategy:
fail-fast: false
Expand All @@ -119,7 +119,7 @@ jobs:
run: |
poetry install -E cli
- name: run ci checks
- name: run cli tests
run: make test-cli

- name: Upload coverage
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test: ## Run tests for Hera

.PHONY: test-cli
test-cli: ## Run tests for Hera
@poetry run python -m pytest --cov-report=term-missing -m 'cli'
@poetry run python -m pytest -m 'cli'

.PHONY: workflows-models
workflows-models: ## Generate the Workflows models portion of Argo Workflows
Expand Down

0 comments on commit b51d164

Please sign in to comment.