Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --include and --exclude to the hera generate yaml command. #904

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

DanCardin
Copy link
Contributor

Pull Request Checklist

Description of PR
Screenshot 2023-12-21 at 8 50 23 AM

Used to fine tune what gets picked up by the CLI, in particular when the FROM is a folder

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecd0c70) 80.3% compared to head (71655f1) 80.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #904   +/-   ##
=====================================
  Coverage   80.3%   80.4%           
=====================================
  Files         49      49           
  Lines       3833    3849   +16     
  Branches     779     787    +8     
=====================================
+ Hits        3081    3097   +16     
  Misses       557     557           
  Partials     195     195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanCardin DanCardin force-pushed the dc/cli-include-exclude branch from 74ef860 to 252b3ed Compare December 21, 2023 14:05
@DanCardin DanCardin marked this pull request as ready for review December 21, 2023 14:09
@flaviuvadan flaviuvadan added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Dec 21, 2023
@sambhav
Copy link
Collaborator

sambhav commented Dec 22, 2023

Could we also additionally have it support variable names?

Potentially using colon. So **:workflow for eg would include all files (by the ** syntax and the latter would only filter it down to workflow variables defined in the files.

@DanCardin
Copy link
Contributor Author

hrm. I was anticipating this filter to be purely about determining the set of input files, and other options might exist to further specialize what gets selected within those files.

Personally, I'd opt for something more like --kind workflow, but which would obviously only work for the whole command. Do you anticipate per-file slash per-glob filtering like that to be important to the above request?

@sambhav
Copy link
Collaborator

sambhav commented Jan 4, 2024

@DanCardin could you please rebase?

@DanCardin DanCardin force-pushed the dc/cli-include-exclude branch from 519b1a3 to 418f32e Compare January 5, 2024 15:21
@DanCardin DanCardin force-pushed the dc/cli-include-exclude branch from 418f32e to 71655f1 Compare January 5, 2024 20:22
@sambhav sambhav merged commit 62a536d into argoproj-labs:main Jan 6, 2024
18 checks passed
@DanCardin DanCardin deleted the dc/cli-include-exclude branch January 6, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants