-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): Add rights on applicationsets for the application controller #20352
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20352 +/- ##
==========================================
- Coverage 55.67% 55.60% -0.08%
==========================================
Files 339 339
Lines 56814 56814
==========================================
- Hits 31634 31590 -44
- Misses 22535 22570 +35
- Partials 2645 2654 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably don't want to do this: argoproj/argo-helm#2974 (comment)
Updated to clarify the namespaced mode intent in the documentation |
@crenshaw-dev are you ok with the content now ? |
Signed-off-by: OpenGuidou <[email protected]>
Upstream fix for: argoproj/argo-helm#2974
Checklist: