chore(appset)!: always apply nested selectors (#14152) #21492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21492 +/- ##
==========================================
- Coverage 55.69% 55.63% -0.07%
==========================================
Files 339 339
Lines 56836 56808 -28
==========================================
- Hits 31657 31605 -52
- Misses 22537 22552 +15
- Partials 2642 2651 +9 ☔ View full report in Codecov by Sentry. |
reggie-k
approved these changes
Feb 2, 2025
agaudreault
reviewed
Feb 3, 2025
Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
agaudreault
approved these changes
Feb 3, 2025
…ted-selectors Signed-off-by: Michael Crenshaw <[email protected]>
…ted-selectors Signed-off-by: Michael Crenshaw <[email protected]>
Sriteja-Tadakaluru
pushed a commit
to Sriteja-Tadakaluru/argo-cd
that referenced
this pull request
Feb 16, 2025
…roj#21492) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…roj#21492) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14152