Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace spdy with websocket for portforward and pod exec #21517 #21518

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

maoqide
Copy link
Contributor

@maoqide maoqide commented Jan 16, 2025

Closes [ISSUE #21517]

As described in related issue, this PR replaced spdy with websocket in argocd.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@maoqide maoqide requested a review from a team as a code owner January 16, 2025 07:29
Copy link

bunnyshell bot commented Jan 16, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@maoqide maoqide force-pushed the replace_spdy_with_websocket branch from 444fe9b to 11763af Compare January 16, 2025 07:32
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 53.35%. Comparing base (9b17495) to head (8c4280d).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
server/application/terminal.go 0.00% 10 Missing ⚠️
util/kube/portforwarder.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21518      +/-   ##
==========================================
- Coverage   55.27%   53.35%   -1.92%     
==========================================
  Files         337      337              
  Lines       56824    56842      +18     
==========================================
- Hits        31407    30326    -1081     
- Misses      22734    23884    +1150     
+ Partials     2683     2632      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I haven't tested so I wont merge yet. Exec is disabled by default in bunnyshell. If anyone else test it and it works, feel free to click merge!

server/application/terminal.go Show resolved Hide resolved
util/kube/portforwarder.go Show resolved Hide resolved
@agaudreault agaudreault requested a review from a team January 16, 2025 20:38
@nitishfy nitishfy self-assigned this Jan 17, 2025
@nitishfy
Copy link
Member

I'll review this PR in a while.

@agaudreault
Copy link
Member

Just tested and terminal is still working

@agaudreault agaudreault merged commit 1698370 into argoproj:master Jan 28, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants