Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(login-cli): Add arguments for port forwarding settings to persist while using the CLI #22521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

D0ri123
Copy link
Contributor

@D0ri123 D0ri123 commented Mar 29, 2025

Fix #20565

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@D0ri123 D0ri123 requested a review from a team as a code owner March 29, 2025 11:53
Copy link

bunnyshell bot commented Mar 29, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@D0ri123 D0ri123 changed the title Feat(login-cli): Add arguments for port forwarding settings to persist while using the CLI feat(login-cli): Add arguments for port forwarding settings to persist while using the CLI Mar 29, 2025
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 56.01%. Comparing base (0ec46f6) to head (2c887e4).

Files with missing lines Patch % Lines
cmd/argocd/commands/login.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22521      +/-   ##
==========================================
- Coverage   56.06%   56.01%   -0.05%     
==========================================
  Files         343      343              
  Lines       57568    57581      +13     
==========================================
- Hits        32274    32253      -21     
- Misses      22649    22675      +26     
- Partials     2645     2653       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant