New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test refactoring, cleanup, and standardization #107

Open

jessesuen opened this issue Jun 14, 2019 · 1 comment

Labels

L no-issue-activity tech debt

Member

jessesuen commented Jun 14, 2019 •

edited

Loading

standardize on helper functions to create new replicasets
standardize on fmt.Sprintf usage (or the removal of it)
provide ability to write tests which verify the end state of rollouts/replicasets, rather than verifying exact order of kuberentes API calls
helpers to avoid hard-coding hashes in tests

jessesuen mentioned this issue

Remove reliance on controller.ComputeHash() for determining changes to pod template spec #104

Merged

jessesuen added the tech debt label

malinafong added this to the v0.7 - Service Mesh + bug fixes milestone

malinafong added the L label

dthomson25 removed this from the v0.7 - Service Mesh + bug fixes milestone

Contributor

github-actions bot commented Dec 7, 2022

This issue is stale because it has been open 60 days with no activity.

github-actions bot added the no-issue-activity label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment