Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on controller.ComputeHash() for determining changes to pod template spec #104

Merged
merged 6 commits into from
Jun 14, 2019

Conversation

jessesuen
Copy link
Member

Resolves: #88

The implementation is complete, but I still need to fix and write unit tests for this.

@jessesuen jessesuen requested review from alexmt and dthomson25 June 12, 2019 01:54
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the potential for a nil pointer exception.

@alexmt can you also take a look since this is a bigger change

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #104 into master will increase coverage by 0.34%.
The diff coverage is 75.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   79.09%   79.43%   +0.34%     
==========================================
  Files          15       15              
  Lines        1808     1838      +30     
==========================================
+ Hits         1430     1460      +30     
- Misses        278      280       +2     
+ Partials      100       98       -2
Impacted Files Coverage Δ
utils/conditions/conditions.go 89.4% <100%> (ø) ⬆️
controller/controller.go 52.6% <100%> (ø) ⬆️
controller/canary.go 85.71% <100%> (+3.3%) ⬆️
controller/pause.go 95.83% <50%> (ø) ⬆️
controller/bluegreen.go 80.79% <62.5%> (-1.13%) ⬇️
utils/replicaset/replicaset.go 88.41% <71.42%> (-5.85%) ⬇️
controller/sync.go 76.34% <88.88%> (+1.57%) ⬆️
controller/service.go 87.75% <0%> (+0.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f35cb0...9e26654. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 2448571 into argoproj:master Jun 14, 2019
@jessesuen jessesuen deleted the 88-pod-hash branch June 14, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in pod template hash after upgrading k8s dependencies
3 participants