-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reliance on controller.ComputeHash() for determining changes to pod template spec #104
Conversation
…o pod template spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have the potential for a nil pointer exception.
@alexmt can you also take a look since this is a bigger change
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 79.09% 79.43% +0.34%
==========================================
Files 15 15
Lines 1808 1838 +30
==========================================
+ Hits 1430 1460 +30
- Misses 278 280 +2
+ Partials 100 98 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves: #88
The implementation is complete, but I still need to fix and write unit tests for this.