Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redo PR 3639 #4114

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: redo PR 3639 #4114

merged 1 commit into from
Feb 6, 2025

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Feb 5, 2025 •
edited
Loading

@zachaller
fix: redo PR 3639
4d2044a 
Signed-off-by: Zach Aller <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zachaller zachaller marked this pull request as ready for review February 5, 2025 19:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Published E2E Test Results

  4 files    4 suites   3h 8m 23s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4d2044a.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Published Unit Test Results

2 294 tests   2 294 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 4d2044a.

@ayureidini ayureidini mentioned this pull request Feb 6, 2025
Closed
leoluz
leoluz approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit ea914af into argoproj:master Feb 6, 2025
25 checks passed
zachaller added a commit that referenced this pull request Feb 6, 2025
@zachaller
fix: redo PR 3639 (#4114)
71a0100 
Signed-off-by: Zach Aller <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

@agaudreault agaudreault agaudreault approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.8 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachaller @leoluz @agaudreault