Link bytecode using references#312
Open
arthcp wants to merge 2 commits intoargotorg:masterfrom
Open
Conversation
axic
force-pushed
the
link-bytecode-using-references
branch
from
b9f2779 to
be228e6
Compare
axic
force-pushed
the
link-bytecode-using-references
branch
2 times, most recently
from
9232d1a to
8dbd9a4
Compare
axic
force-pushed
the
link-bytecode-using-references
branch
from
8dbd9a4 to
8cc1dee
Compare
r0qs
force-pushed
the
link-bytecode-using-references
branch
from
d8c2553 to
01dd7ca
Compare
Collaborator
|
@r0qs I see there's a merge commit. Can you rebase it on top of |
r0qs
force-pushed
the
link-bytecode-using-references
branch
from
01dd7ca to
7536d10
Compare
Member
Yes. I did it now, but as the commits were very old and the file structures changed significantly, the OP changes needed to be discarded during the rebase. However, I added the OP as a co-author of my changes, since I reused part of his solution. |
Co-authored-by: arthcp <arth.c.patel@gmail.com>
r0qs
force-pushed
the
link-bytecode-using-references
branch
from
7536d10 to
954e6f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support to provide
linkReferencesas optional third parameter forlinkBytecode. If it is not provided thenfindLinkReferencesis used to find it. If library name is not present inlinkReferencesthen it falls back to manual search.Fixes #193