feat: Add persistent sidebar overlay toggle in command palette #71
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a config file option, allow toggling sidebar overlay behavior directly from the command palette. The state persists to kv.json. Changes: - Add sidebarOverlayEnabled signal persisted to kv.json (defaults to true) - Add sidebarOverlay toggle command in System category - Add optional sidebar_overlay_toggle keybind config (default: none) This provides instant toggling without requiring restart/reload.
Resolved conflict in contentWidth calculation by preserving overlay behavior logic from feature branch.
…m:ariane-emory/opencode into feat/persistant-sidebar-overlay-behaviour
…m:ariane-emory/opencode into feat/persistant-sidebar-overlay-behaviour
…m:ariane-emory/opencode into feat/persistant-sidebar-overlay-behaviour
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
ariane-emory
force-pushed
the
feat/persistant-sidebar-overlay-behaviour
branch
3 times, most recently
from
57a27df to
860b120
Compare
The sidebarOverlay() memo was computed but never used in rendering. Changed the Switch/Match conditions from wide() to sidebarOverlay() so the toggle command actually controls overlay behavior.
The explicit kv.set() inside the setter callback was causing a nested setStore that interfered with SolidJS reactive tracking. This made the toggle appear to work (value persisted) but the UI wouldn't update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.
Instead of a config file option, allow toggling sidebar overlay behavior directly from the command palette. The state persists to kv.json.
Changes:
This provides instant toggling without requiring restart/reload.