forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: sort modal menu options alphabetically with prefix matches first #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ariane-emory
wants to merge
57
commits into
dev
Choose a base branch
from
fix/modal-menus-filtered-order
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DialogSelect: Add prefix-first alphabetical sorting to filtered results - Remove commented-out sort in grouped memo since sorting is now done in filtered() - DialogModel: Add sortWithPrefixFirst helper for custom filtering logic - Preserve 'Free first' ordering within filtered groups - Ensures consistent alphabetical ordering in /theme and /models menus
Resolved merge conflict in dialog-model.tsx by combining: - Advanced prefix-first sorting with 'Free first' ordering from fix branch - Recents limit to 5 items from dev branch Both filtering and sorting improvements are now preserved.
…ory/opencode into fix/modal-menus-filtered-order
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6eb171b to
239fed6
Compare
f5dc48d to
239fed6
Compare
Successfully merged dev changes with 88 files changed. Resolved new OAuth callback test failure by clearing port conflict with external process. All tests now pass (OAuth callback test: 1 pass, 0 fail).
…on that handles port conflicts properly
Resolved conflicts: - Removed oauth-callback.test.ts (deleted in dev) - Updated oauth-callback.ts to use dev branch's simpler ensureRunning() approach with port checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.