Fix/persist sidebar #80
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix kv.signal() to not overwrite persisted values during async load - Update Session component to use kv.signal() for sidebar state - Remove redundant kv.set() calls in sidebar toggle - Ensure sidebar state (show/hide/auto) persists correctly across restarts
…de into feat/sinister-quotes
…de into feat/sinister-quotes
…mory/opencode into fix/persist-sidebar
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
ariane-emory
force-pushed
the
fix/persist-sidebar
branch
from
4316e48 to
a4c92e6
Compare
ariane-emory
force-pushed
the
fix/persist-sidebar
branch
from
c4a1a70 to
692b7ca
Compare
The sidebarVisible memo was only checking for sidebar() === 'auto', but this branch added a third state 'show'. When sidebar is 'show' and the app restarts, sidebarOpen (an ephemeral signal) resets to false, causing the sidebar to not appear until toggled twice. This adds the missing check for sidebar() === 'show' to properly restore sidebar visibility on app restart. Also fixes kv.signal setter patterns to not use function syntax (kv.signal setters take values directly, not functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.