Skip to content

Make _shallow_copy public #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ameligrana wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Make _shallow_copy public #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0915177
Make _shallow_copy public
ameligrana Jan 24, 2026
cac4548
Export shallow_copy function from Ark.jl
ameligrana Jan 24, 2026
de9eccd
Update storage.jl
ameligrana Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Ark.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,6 @@ export Relationship

export Storage, StructArray, GPUStructArray, GPUVector

export shallow_copy

end
2 changes: 1 addition & 1 deletion src/storage.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ end
push!(exprs, :(push!(new_vec, old_vec[old_row])))
elseif CP === Val{:copy} || all(T -> isbitstype(T), fieldtypes(C))
# no deep copy required for types with all isbits fields
push!(exprs, :(push!(new_vec, _shallow_copy(old_vec[old_row]))))
push!(exprs, :(push!(new_vec, shallow_copy(old_vec[old_row]))))
else # CP === Val{:deepcopy}
# validity if checked before the call.
push!(exprs, :(push!(new_vec, deepcopy(old_vec[old_row]))))
Expand Down
2 changes: 1 addition & 1 deletion src/util.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function _format_type(T)
end
end

@generated function _shallow_copy(x::T) where T
@generated function shallow_copy(x::T) where T
if T == Symbol || T == String
return :(x)
end
Expand Down
Loading