Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armbian ConfigNG desktop entry and icons #86

Closed
wants to merge 6 commits into from
Closed

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 19, 2024

Description

configng
16x16

others
32x32-256x256 and SVG

Implementation Details

  • Key changes introduced by this PR

    • Added icon files in multiple sizes (16x16, 32x32, 64x64, 128x128, 256x256) and a scalable SVG format.
    • Created a desktop launcher file configng.desktop to allow easy access from the desktop environment.
  • Justification for the changes
    The inclusion of different icon sizes ensures that the application icon appears crisp and appropriately scaled across various display settings. The desktop launcher file simplifies user access to the application, improving usability and integration with desktop environments.

  • Confirmation that no new external dependencies or modules have been introduced
    No new external dependencies have been added. The changes only involve adding icon files and a desktop launcher configuration.

Testing Procedure

  • Test 1: Verified that the icons appear correctly in various sizes (16x16, 32x32, 64x64, 128x128, 256x256) when used in the desktop launcher and application menu.

    • Results: Icons displayed correctly in all tested sizes.
  • Test 2: Tested the desktop launcher by placing it on the desktop and verifying that it launches the application as expected.

    • Results: The desktop launcher successfully starts the application.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@Tearran Tearran added the ready label Sep 19, 2024
@Tearran
Copy link
Member Author

Tearran commented Sep 19, 2024

Added alternative scalable icon for 32x32-256x256

configng-cpu

@Tearran
Copy link
Member Author

Tearran commented Sep 19, 2024

Add script to resize, convert, and place icons in appropriate locations

  • Added a script (./tools/svg-png.sh) to convert an SVG file into PNG files of sizes 32x32, 64x64, 128x128, and 256x256 pixels.
  • The script places the converted PNG files in their respective size-specific folders.
  • Example usage: ./tools/svg-png.sh configng-cpu will resize and convert ./share/icons/hicolor/scalable/apps/configng-cpu.svg.
  • Note: Inkscape must be installed for the script to work.

@Tearran Tearran changed the title add: Armbian ConfigNG desktop entry and icons Armbian ConfigNG desktop entry and icons Sep 20, 2024
@Tearran Tearran removed the ready label Sep 21, 2024
@Tearran Tearran closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant