Skip to content

Surface armbian-sdk images with Code server logo#138

Open
igorpecovnik wants to merge 1 commit into
mainfrom
sdk-app-metadata
Open

Surface armbian-sdk images with Code server logo#138
igorpecovnik wants to merge 1 commit into
mainfrom
sdk-app-metadata

Conversation

@igorpecovnik
Copy link
Copy Markdown
Member

Summary

Mirrors armbian/website#19 on the imager side. SDK images carry application: "sdk" end-to-end; this PR adds the matching APP_INFO and appLogos entries so the imager renders them with the code-server logo and the label Code server + Armbian sources instead of falling back to a generic icon.

How the data reaches imager

  1. The armbian/build composite action writes per-image manifests with file_application: "sdk" (the kernel suffix 6.18.26-sdk is detected via the manifest writer's last_token.isalpha() rule).
  2. armbian/armbian.github.io#306 merges the SDK's armbian-images.json into the canonical index verbatim, preserving the application field.
  3. Imager already consumes the canonical index. With this PR, getAppInfo("sdk") and getImageLogo(_, "sdk") resolve correctly.

Related

Test plan

  • Once #306 lands and the SDK rows reach the imager catalogue, confirm the SDK images render with the code-server logo and the Code server + Armbian sources label.
  • Other applications (Home Assistant, OpenMediaVault) are unaffected.
  • Generic fallback icon path is unchanged for images without an application field.

Adds the SDK ('sdk' application key) to APP_INFO and appLogos so SDK
images surface in the imager UI with the code-server logo and the
label 'Code server + Armbian sources', matching the website's
treatment.

The application key flows through end-to-end already: build action's
manifest writer tags file_application=sdk from the kernel '-sdk'
suffix, and the third-party merge step on armbian.github.io
preserves the field while folding the SDK manifest into the canonical
armbian-images.json that the imager consumes.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🧪 Test Builds

Version: 0.0.0-pr.138 | PR: #138 | Status: ready for testing

Platform Download
Linux x64 📦 .deb / .AppImage
Windows x64 📦 .exe
macOS ARM64 📦 .dmg
ℹ️ About these builds
  • 🔓 Public downloads via nightly.link (no GitHub login required)
  • ⚠️ Unsigned builds for testing purposes only
  • Expires in 7 days
  • 🔄 Updated on every push to this PR

@github-actions github-actions Bot added the status: ready for review Ready to be reviewed label May 6, 2026
@igorpecovnik
Copy link
Copy Markdown
Member Author

image

@SuperKali
Copy link
Copy Markdown
Member

@igorpecovnik Those images are only SDK? no CLI or Desktop?

@igorpecovnik
Copy link
Copy Markdown
Member Author

Those images are only SDK? no CLI or Desktop?

Minimal with some stuff. In theory, they could be desktop variant too.

@SuperKali
Copy link
Copy Markdown
Member

Minimal with some stuff. In theory, they could be desktop variant too.

Is this mentioned anywhere? Because listing only the SDK as a badge isn't ideal; it would be better to include the CLI as a badge or specify the type of desktop environment, such as GNOME.

@igorpecovnik
Copy link
Copy Markdown
Member Author

Is this mentioned anywhere? Because listing only the SDK as a badge isn't ideal; it would be better to include the CLI as a badge or specify the type of desktop environment, such as GNOME.

Probabla best solution is to add those labels one after another.

[ CLI ] [EDGE] [GNOME] [SDK]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready for review Ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants